Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add svmlin & svmsgd meta example #4404

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Add svmlin & svmsgd meta example #4404

merged 2 commits into from
Oct 31, 2018

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Oct 11, 2018

Two files are missing from previous pr #4361, data shogun-toolbox/shogun-data#168
See also #4400

@karlnapf
Copy link
Member

What’s the errors?

@vinx13
Copy link
Member Author

vinx13 commented Oct 12, 2018

@karlnapf any idea?
https://travis-ci.org/shogun-toolbox/shogun/jobs/440594267#L1887

@karlnapf
Copy link
Member

uff this seems like a python version problem. Can you reproduce this error locally? I bet it is some upgrade to Python 3

@vinx13
Copy link
Member Author

vinx13 commented Oct 12, 2018 •
edited
Loading

there are some error on windows about variant since 7c7693f, i guess that's some compiler version issue
error on travis is since 078606d see https://travis-ci.org/shogun-toolbox/shogun/jobs/434524177#L1848

@karlnapf
Copy link
Member

the windows variant error for sure is compiler version
But the Python error, what about that? We should get at least travis green

@vinx13 vinx13 force-pushed the meta/classifier_2 branch 2 times, most recently from ef2b569 to fe19f34 Compare October 13, 2018 04:46
@vinx13
Copy link
Member Author

vinx13 commented Oct 31, 2018

@karlnapf travis gets green now

@karlnapf
Copy link
Member

Great, thanks for the ping and let's merge

@karlnapf
Copy link
Member

@vinx13 would you min checking the variant compiler error on windows? At least googling the source a bit?

@karlnapf karlnapf merged commit f6efd89 into shogun-toolbox:develop Oct 31, 2018
@vinx13
Copy link
Member Author

vinx13 commented Nov 1, 2018

the variant error on windows seems a MSVC issue, see mpark/variant#49
I will update version of variant

vigsterkr pushed a commit to vigsterkr/shogun that referenced this pull request Mar 9, 2019
@vinx13 @vigsterkr
Add svmlin & svmsgd meta example (shogun-toolbox#4404)
e2f4f99 
* Add svmlin & svmsgd meta example
* Update integration data
ktiefe pushed a commit to ktiefe/shogun that referenced this pull request Jul 30, 2019
@vinx13 @ktiefe
Add svmlin & svmsgd meta example (shogun-toolbox#4404)
79e4350 
* Add svmlin & svmsgd meta example
* Update integration data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vinx13 @karlnapf